Verifier Optimization #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization for IPA verifier from Bulletproofs Section 3.1 - delays exponentiations until they can be combined, batched inversions (Microsoft's Spartan used as code reference)
Two notes:
This optimization deals with a section of code that both the Prover and Verifier run (see Hyrax fig 7, step 4). Not sure if I should implement the optimization for the prover as well? (Spartan does not optimize it's prover.)
I do batch inversions using code ported from Spartan's
batch_inversionmethod. This method useszeroizeto clear a scratch buffer (here). I'm not sure how to port this feature, as Nova uses the pasta curves, without a wrapper around them (unlike how Spartan's wrapper around Scalars), so I can't implementZeroizefor the field elements. There's probably an elegant solution to this?